Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1533 #1534

Merged
merged 4 commits into from
Jun 19, 2020
Merged

Fix for #1533 #1534

merged 4 commits into from
Jun 19, 2020

Conversation

oleibman
Copy link
Collaborator

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

Code assumes that formula whose result starts with # indicates error.
Change to check entire result against error list in Functions.

Resync with base project
Code assumes that formula whose result starts with # indicates error.
Change to check entire result against error list in Functions.
@MarkBaker
Copy link
Member

Yes, a bad assumption to make. Thank you for the fix.

@MarkBaker MarkBaker merged commit d8b4c3b into PHPOffice:master Jun 19, 2020
@oleibman oleibman deleted the bug1533 branch November 2, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants